Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Progress Bar During Installation #7

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Pheon-Dev
Copy link
Contributor

Separated it to its own scripts so that it could be reused in the plugin installation

@Pheon-Dev Pheon-Dev merged commit 16b7fc3 into zap-zsh:master Nov 7, 2022
@Granddave
Copy link
Member

The script separation broke the install script since the curl command only downloads the install.sh not also the progress.zsh file.
I also believe that the progress bar doesn't reflect the actual progress since running ./install.sh without the progress bar code is much faster than installing it with the progress bar code... :)

@Pheon-Dev
Copy link
Contributor Author

Will remove it and do as plugin installation works instead of bloating the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants