Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Add assertion for number of qubits in Circuit init #425

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

Shiro-Raven
Copy link
Contributor

No description provided.

@Shiro-Raven Shiro-Raven requested a review from a team September 21, 2021 13:07
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #425 (d8d5318) into dev (f53a327) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #425      +/-   ##
==========================================
+ Coverage   90.88%   90.89%   +0.01%     
==========================================
  Files          63       63              
  Lines        3564     3571       +7     
  Branches      571      574       +3     
==========================================
+ Hits         3239     3246       +7     
  Misses        217      217              
  Partials      108      108              
Impacted Files Coverage Δ
src/python/zquantum/core/circuits/_circuit.py 90.14% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dcb7b...d8d5318. Read the comment docs.

Copy link
Contributor

@dexter2206 dexter2206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an unused import in _circuit.py, otherwise looks good!

src/python/zquantum/core/circuits/_circuit.py Outdated Show resolved Hide resolved
@Shiro-Raven Shiro-Raven merged commit 994ac0c into dev Sep 21, 2021
@Shiro-Raven Shiro-Raven deleted the feature/ZQS-60/shiro-raven/add-assertion-n-qubits branch September 21, 2021 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants