Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

ZQS-770 Make natural_key_revlex a default #427

Merged

Conversation

dexter2206
Copy link
Contributor

This makes natural_key_revlex a default key for sorting symbols in ansatz.

As a reminder, using the aforementioned key results in the following order (assuming ansatz has symbols alpha_i, beta_j:
alpha_0 < beta_0 < alpha_1 < beta_1 < alpha_2 < beta_2 < alpha_3 < beta_3 < ....

@dexter2206 dexter2206 requested a review from a team September 23, 2021 11:40
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #427 (4287694) into dev (d285f7f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #427      +/-   ##
==========================================
- Coverage   90.94%   90.91%   -0.03%     
==========================================
  Files          63       63              
  Lines        3577     3577              
  Branches      575      575              
==========================================
- Hits         3253     3252       -1     
  Misses        217      217              
- Partials      107      108       +1     
Impacted Files Coverage Δ
src/python/zquantum/core/interfaces/ansatz.py 75.00% <100.00%> (ø)
src/python/zquantum/core/openfermion/_utils.py 91.16% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d285f7f...4287694. Read the comment docs.

@dexter2206 dexter2206 merged commit 0ecf099 into dev Sep 23, 2021
@dexter2206 dexter2206 deleted the bugfix/dexter2206/ZQS-770-make-natural_key_revlex-a-default branch September 23, 2021 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants