Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown workflow: support both .md and .MD extension for markdown files #24

Merged
merged 16 commits into from
Aug 22, 2023
Merged

Markdown workflow: support both .md and .MD extension for markdown files #24

merged 16 commits into from
Aug 22, 2023

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Aug 22, 2023 •
edited
Loading

Description

Markdown workflow: Support both .md and .MD extension for markdown files

Changes Made

  • Support both .md and .MD extension for markdown files in prettier
  • Support both .md and .MD extension for markdown files in linter

Related Issues

Fixes #23

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 linked an issue Aug 22, 2023 that may be closed by this pull request
[Bug]: markdown workflow is extension case sensitive #23
Closed
@chicco785 chicco785 self-assigned this Aug 22, 2023
@chicco785 chicco785 added the bug This issue/PR relates to a bug. label Aug 22, 2023
@chicco785 chicco785 changed the title Support both .md and .MD extension for markdown files Markdown workflow: support both .md and .MD extension for markdown files Aug 22, 2023
@chicco785
Copy link
Member Author

to support uppercase extension in the link checker step, we need to modify the related action.

@chicco785 chicco785 requested a review from MarcoPignati August 22, 2023 21:33
@MarcoPignati MarcoPignati merged commit 2970a36 into main Aug 22, 2023
@MarcoPignati MarcoPignati deleted the 23-bug-markdown-workflow-is-extension-case-sensitive branch August 22, 2023 22:31
@chicco785 chicco785 changed the title Markdown workflow: support both .md and .MD extension for markdown files Markdown workflow: support both .md and .MD extension for markdown files Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPignati MarcoPignati MarcoPignati approved these changes

Assignees

@chicco785 chicco785

Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: markdown workflow is extension case sensitive
2 participants
@chicco785 @MarcoPignati