Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang: remove code coverage annotations #76

Merged
merged 5 commits into from
Dec 20, 2023
Merged

golang: remove code coverage annotations #76

merged 5 commits into from
Dec 20, 2023

Conversation

hiimjako
Copy link
Contributor

Description

Even though only errors are shown, it makes reading PRs difficult. Therefore, I would remove all the annotations.

Changes Made

Related Issues

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@hiimjako hiimjako added the refactor This issue/PR relates to refactoring. label Dec 20, 2023
@hiimjako hiimjako self-assigned this Dec 20, 2023
@hiimjako hiimjako requested review from cosimomeli and a team December 20, 2023 16:45
tejo
tejo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tejo tejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES PLEASE!!!

@hiimjako
Copy link
Contributor Author

@cosimomeli can you confirm that this should remove all the annotations from PRs?

@cosimomeli cosimomeli changed the title Remove annotiation in PRs Remove code coverage annotations Dec 20, 2023
@cosimomeli cosimomeli changed the title Remove code coverage annotations golang: remove code coverage annotations Dec 20, 2023
@cosimomeli
Copy link
Contributor

@cosimomeli can you confirm that this should remove all the annotations from PRs?

I confirm that the empty config should disable all the annotations according to the action's documentation.

@cosimomeli cosimomeli added feature This issue/PR relates to a feature request. and removed refactor This issue/PR relates to refactoring. labels Dec 20, 2023
@hiimjako hiimjako merged commit b49dc09 into main Dec 20, 2023
8 checks passed
@hiimjako hiimjako deleted the hiimjako-patch-1 branch December 20, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimomeli cosimomeli cosimomeli approved these changes

@tejo tejo tejo approved these changes

Assignees

@hiimjako hiimjako

Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiimjako @cosimomeli @tejo