Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on develop branch #886

Open
jochenjagers opened this issue Apr 28, 2020 · 1 comment
Open

Test fails on develop branch #886

jochenjagers opened this issue Apr 28, 2020 · 1 comment
Labels
Bug Core Fixed Issue is fixed but not yet released
Milestone

Comments

@jochenjagers
Copy link

Hello,

connection_test gives me an error.
Looks like URI parsing is not working correct anymore.
The URI for this test is "ws://localhost".
The error is directly after the "GET". "/" is expected but "t" is in the request.

fc41dd5 is the last working commit.

Test result below:

./test_connection_boost 
Running 17 test cases...
test/connection/connection.cpp(325): error: in "basic_client_websocket": check ref == output.str() has failed 
[GET / HTTP/1.1
Connection: Upgrade
Foo: Bar
Host: localhost
Sec-WebSocket-Key: AAAAAAAAAAAAAAAAAAAAAA==
Sec-WebSocket-Version: 13
Upgrade: websocket
User-Agent: foo

 != GET t HTTP/1.1
Connection: Upgrade
Foo: Bar
Host: localhost
Sec-WebSocket-Key: AAAAAAAAAAAAAAAAAAAAAA==
Sec-WebSocket-Version: 13
Upgrade: websocket
User-Agent: foo

]

*** 1 failure is detected in the test module "connection"

Greetings
Jochen

@zaphoyd
Copy link
Owner

zaphoyd commented Apr 28, 2020

Good catch, thanks! This has been fixed and the uri string that was causing problems has been pulled into the URI test suite.

@zaphoyd zaphoyd added the Fixed Issue is fixed but not yet released label Jun 30, 2020
@zaphoyd zaphoyd added 0.9.x and removed 0.9.x labels Aug 7, 2020
@zaphoyd zaphoyd added this to the 0.9.0 milestone Aug 7, 2020
TwentyPast4 pushed a commit to TroniusGaming/websocketpp that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Core Fixed Issue is fixed but not yet released
Projects
None yet
Development

No branches or pull requests

2 participants