Add a better error message when uploading with a zip

zapier · Mar 13, 2019 · aebf3b8 · aebf3b8
1 parent b688200
commit aebf3b8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/src/commands/upload.js b/src/commands/upload.js
@@ -3,13 +3,16 @@ const utils = require('../utils');
 
 const upload = context => {
   context.line('Preparing to upload a new version.\n');
-  return utils.upload().then(() => {
-    context.line(
-      `\nUpload of ${constants.BUILD_PATH} and ${
-        constants.SOURCE_PATH
-      } complete! Try \`zapier versions\` now!`
-    );
-  });
+  return utils
+    .upload()
+    .then(() => {
+      context.line(
+        `\nUpload of ${constants.BUILD_PATH} and ${
+          constants.SOURCE_PATH
+        } complete! Try \`zapier versions\` now!`
+      );
+    })
+    .catch(error => Promise.reject(error));
 };
 upload.argsSpec = [];
 upload.argOptsSpec = {};

diff --git a/src/utils/api.js b/src/utils/api.js
@@ -270,6 +270,13 @@ const upload = (zipPath, sourceZipPath, appDir) => {
 
   const fullZipPath = path.resolve(appDir, zipPath);
   const fullSourceZipPath = path.resolve(appDir, sourceZipPath);
+  const isMissingZip = !fs.existsSync(fullZipPath);
+
+  if (isMissingZip) {
+    return Promise.reject(
+      new Error('Missing a built app. Trying running `zapier push`.')
+    );
+  }
 
   return getLinkedApp(appDir)
     .then(app => {