Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Adding a command to test converted apps. #175

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

BrunoBernardino
Copy link
Contributor

Only including a simple basic auth (and a trigger with no scripting). It's failing because we don't add tests yet, but once we do it should start passing.

We should also keep adding WB apps there as we support more scripting methods to be converted.

Only including a simple basic auth (and a trigger with no scripting). It's failing because we don't add tests yet, but once we do it should start passing.

We should also keep adding WB apps there as we support more scripting methods to be converted.
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled and tested it on my local environment. The only feedback I have is that we should remove those ANSI escape codes from the convert logs. We can do that in a separate PR. Other than that, it Looks pretty straightforward.

@BrunoBernardino BrunoBernardino merged commit f2c44cc into master Nov 7, 2017
@BrunoBernardino BrunoBernardino deleted the feature-convert-tester branch November 7, 2017 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants