This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
zapier convert: Generate create code based on different scripting method combinations #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoBernardino
suggested changes
Nov 13, 2017
There was a problem hiding this comment.
This looks great @eliangcs ! We're just missing some default code that would work for when the app has no scripting.
scaffold/convert/create.template.js
Outdated
| data: JSON.stringify({ | ||
| EXAMPLE: bundle.inputData.EXAMPLE | ||
| }) | ||
| url: '<%= URL %>' |
There was a problem hiding this comment.
We should keep the method: 'POST' here, and add body: bundle.inputData after, so we're sending data by default.
There was a problem hiding this comment.
Thanks for finding that out! Fixed in 9a7d906.
BrunoBernardino
approved these changes
Nov 14, 2017
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.