Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

zapier convert: Create .gitignore for converted app #237

Merged
merged 2 commits into from
Feb 14, 2018
Merged

zapier convert: Create .gitignore for converted app #237

merged 2 commits into from
Feb 14, 2018

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Feb 14, 2018 •
edited
Loading

Should be pretty straightforward. This PR creates a typical Node.js .gitignore for the converted app.

@eliangcs eliangcs requested a review from xavdid February 14, 2018 04:23
xavdid
xavdid approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great call on including both .env and .environment! build is the other one i'd include, but I see that it's there for a separate reason. No matter, it'll work for us!

@eliangcs eliangcs merged commit 02c25dc into master Feb 14, 2018
@eliangcs eliangcs deleted the convert-gitignore branch February 14, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliangcs @xavdid