This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
read deploy key from env if available #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses PDE-59.
Fixed a potential bug on the way: the only place
readCredentialsactually returned a value, it was expect to return an object with thedeployKeykey. The function also takes a param if you want to pass in a key, and would echo it. The issue was that it would echo the value, not wrapped in the object as was expected.To that end, nowhere in the codebase actually passes in a
credentialsvalue. That function signature complicates some calls (ie:readCredentials(null, false)) and unless it's there for a reason (@bryanhelmig; sorry for the double ping) I propose we remove the parameter entirely.