This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
zapier convert: Add track info in converted app's package.json #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
approved these changes
Feb 20, 2018
There was a problem hiding this comment.
awesome change! will definitely help our foggy memories.
Only other thing i'd do is add a single test somewhere that expects the zapier. convertedByCLIVersion value to be truthy in the output app. Not a big deal if that's not an easy line to drop into a test, but if it's already mostly there, a worthwhile add
src/utils/convert.js
Outdated
| @@ -5,6 +5,7 @@ const stripComments = require('strip-comments'); | |||
| const { camelCase, snakeCase } = require('./misc'); | |||
| const { copyFile, readFile, writeFile, ensureDir } = require('./files'); | |||
| const { printStarting, printDone } = require('./display'); | |||
| const CLI_VERSION = require('../../package.json').version; | |||
There was a problem hiding this comment.
can import from constants: https://github.com/zapier/zapier-platform-cli/blob/master/src/constants.js#L26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to custom fields to the converted app's
package.json:convertedFromAppID: the source WB app which was being converted to CLIconvertedByCLIVersion: the CLI version that was used to performzapier convertThe two fields are nested in a field named
zapier, which allows us to add any other custom fields in the future.