Adding the option to show bundle logs #291
Conversation
Also improved the `zapier help logs` to not show so many examples, because it pushed the helpful argument list to above the fold, which was annoying. Closes [PDE-153](https://zapierorg.atlassian.net/secure/RapidBoard.jspa?rapidView=13&projectKey=PDE&modal=detail&selectedIssue=PDE-153) and depends on https://github.com/zapier/zapier/pull/16608
BrunoBernardino
requested review from
xavdid and
eliangcs
and removed request for
xavdid
There was a problem hiding this comment.
Pulled and tested. Works as expected!
I have a question, probably irrelevant to this PR, though. Isn't the default output format table? Why does zapier logs --type=bundle always give me a plain format output like the following, even if I specify --format=table?
== Log
Invoked method triggers.KEY.operation.perform
== Input
{ ... }
== Output
{ ... }
== Version
1.0.0
== Timestamp
...
| <h3 id="viewing-bundle-logs">Viewing Bundle Logs</h3> | ||
| </div> | ||
| <div class="col-md-7 col-sm-12 col-height is-empty docs-code"> | ||
|
|
There was a problem hiding this comment.
Nit: git check doesn't like the trailing whitespace here:
$ git show --oneline --check origin/pr/291
5fac9b5 (origin/pr/291, origin/feature-bundle-logs) Updating docs.
docs/index.html:3139: trailing whitespace.
+ There was a problem hiding this comment.
Nice catch @wking ! That's generated by https://github.com/zapier/litdoc so if you could please report that there, it'd be great!
|
@eliangcs great question! It's because of the length of the data there (it's always quite big). Tables only work for a certain length: zapier-platform-cli/src/utils/display.js Lines 101 to 102 in 43f2356 |
Also improved the
zapier help logsto not show so many examples, because it pushed the helpful argument list to above the fold, which was annoying.Closes PDE-153 and depends on
https://github.com/zapier/zapier/pull/16608