Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Fix bug: zapier push doesn't stop on validation errors #388

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Jan 11, 2019

Fixes #387, a bug introduced to 7.6.0 by PR #382.

Steps to reproduce:

  1. zapier init example-app
  2. zapier push with some random name
  3. create a trigger with a very short description (length < 12)
  4. zapier validate would show an error
  5. bump version to 1.0.1 in package.json
  6. zapier push shows success, but 1.0.1 wasn't really pushed

@eliangcs eliangcs requested a review from xavdid January 11, 2019 04:50
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, dang. thanks for grabbing. turns out refactoring promises has a couple of potholes. 😬

@eliangcs eliangcs merged commit e4317a4 into master Jan 18, 2019
@eliangcs eliangcs deleted the push-should-stop-on-validation-errors branch January 18, 2019 21:32
@kgodtfredsen
Copy link

Heya, how can I tell if this fix has been deployed? I had a customer run into this today and could recreate, so we both still have the older versions installed.

@xavdid
Copy link
Contributor

xavdid commented Jan 24, 2019

@kgodtfredsen this is not yet deployed. We release CLI every 2 weeks typically (though that schedule was disrupted by holidays and retreat). You can see what's been released in the changelog

If anything, I think this is worth a bugfix release sooner rather than later @eliangcs.

@kgodtfredsen
Copy link

Thanks @xavdid, I'll keep the changelog link around and make sure the dev tracks it too.

@xavdid
Copy link
Contributor

xavdid commented Jan 25, 2019

@kgodtfredsen v7.6.1 went out early this morning with the fix in tow! Thanks for reminding us.

@kgodtfredsen
Copy link

@xavdid thanks much for this work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants