Encode form requests with + instead of %20 by default #52
Conversation
Most apps and the specs (read https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent on application/x-www-form-urlencoded) expect a plus sign instead of %20. Tests were also added. This will probably require a breaking release.
|
@eliangcs that's a good point. I'm not sure we wouldn't want those converted, though. We're just trying to keep the spaces converted to Does that make sense, or am I missing something? |
|
@BrunoBernardino I just realized that I was confused. You're right: |
| @@ -39,8 +39,7 @@ const coerceBody = (req) => { | |||
|
|
|||
| // auto coerce form if header says so | |||
| if (contentType === FORM_TYPE && req.body && !_.isString(req.body)) { | |||
| // TODO: use const FormData = require('form-data'); instead? | |||
| req.body = querystring.stringify(req.body); | |||
| req.body = querystring.stringify(req.body).replace(/%20/g, '+'); | |||
There was a problem hiding this comment.
Sanity check that node doesn't have a built-in lib to do the encoding the way we want, vs having to do this find and replace?
There was a problem hiding this comment.
Nice idea! Unfortunately there isn't, because we want to do it for everything but spaces. The options for that method only include sending a function that's encodeURIComponent by default.
Most apps and the specs (read https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent on application/x-www-form-urlencoded) expect a plus sign instead of %20 in this situation.
Tests were also added. This will probably require a breaking release.
Fixes zapier/zapier-platform-cli#161
Thoughts @bcooksey ?