Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Remove Order #27

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Remove Order #27

merged 3 commits into from
Feb 19, 2018

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Dec 8, 2017

Order doesn't actually do anything, so we're pulling it. This is a SEMVER.MAJOR change. See trello card.

Order doesn't actually do anything, so we're pulling it. This is a `SEMVER.MAJOR` change.
@xavdid xavdid requested review from BrunoBernardino and eliangcs and removed request for BrunoBernardino December 8, 2017 20:55
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. But I'd like to halt the merge until we release a 4.x compatible version for zapier/zapier-platform-core#56.

@xavdid
Copy link
Contributor Author

xavdid commented Dec 12, 2017

No problem, no rush here. it can't get merged until we're ready for 5.0. I'll add a note in the docs in the meantime.

@xavdid xavdid mentioned this pull request Dec 12, 2017
@xavdid xavdid merged commit bd0aa8a into master Feb 19, 2018
@xavdid xavdid deleted the remove-order branch February 19, 2018 21:24
@xavdid xavdid added the MAJOR label Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants