[MAJOR] add matching keys functional constraint

[xavdid]

Adds a new functional constraint to validate the fact that the top-level key in a trigger/search/create matches the key value. Failing to do this causes a wild bug where the trigger is in the definition twice.

This is because in core, we run the following in compileApp (link), which copies properties onto the wrong key if they don't match. A simple example:

const o = { a: { key: "a" }, b: { key: "c" } };

_.each(o, val => {
  o[val.key] = { checked: true, ...val };
});

JSON.stringify(o, null, 2)

yields:

{
  "a": {
    "checked": true,
    "key": "a"
  },
  "b": {
    "key": "c"
  },
  "c": {
    "checked": true,
    "key": "c"
  }
}

where c is in the definition twice, but one is a bad version.

See: initial slack report

[eliangcs]

Pulled and confirmed it works as expected! I only have one question on the code. Thanks!

[eliangcs]

Doesn't looks like this if block is necessary. The for loop that follows next should safely exit even definition doesn't have any of actionTypes. Or am I missing something?