This repository has been archived by the owner on May 17, 2024. It is now read-only.
Whitelist files in package #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
suggested changes
Jun 14, 2018
package.json
Outdated
| @@ -7,6 +7,10 @@ | |||
| "author": "Bryan Helmig <bryan@zapier.com>", | |||
| "license": "UNLICENSED", | |||
| "main": "schema.js", | |||
| "files": [ | |||
| "/exported-schema.json", | |||
| "/lib/**/*.js" | |||
There was a problem hiding this comment.
needs:
- schema.js
also in lib/utils, 3/5 of those files are just for docs. If we're really trying to cut down on size, we'd either explicitly exclude those 3 or include the two (makeSchema and makeValidator) that we need
There was a problem hiding this comment.
Fixed in 58a8cb6.
I tested on my local. We actually need lib/utils/exportSchema.js and lib/utils/links.js because they're imported internally somewhere in zapier-platform-schema. By this rationale, I think it's better just to include all the files in /lib as other modules in zapier-platform-schema may want to use them.
|
@xavdid updated the PR. Thanks! |
xavdid
approved these changes
Jun 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same stuff as zapier/zapier-platform-cli#330.