Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

(docs) be more clear about whether hook methods are required #58

Merged
merged 2 commits into from
Nov 1, 2018
Merged

(docs) be more clear about whether hook methods are required #58

merged 2 commits into from
Nov 1, 2018

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Oct 31, 2018

Adds a doc annotation to make the hook implementation requirements more clear. Fixes zapier/zapier-platform-cli#364.

@arkwright, if you want to peek / have feelings about it

@xavdid xavdid requested a review from eliangcs October 31, 2018 22:27
@xavdid xavdid changed the title be more clear about whether hook methods are required (docs) be more clear about whether hook methods are required Oct 31, 2018
eliangcs
eliangcs approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the confusion! Only got one suggestion. The diff in package-lock.json may come from an old version of npm. Can you upgrade npm and rerun npm install to get rid of the diff in package-lock.json?

@xavdid
Copy link
Contributor Author

xavdid commented Nov 1, 2018

That's weird. We don't even need a lockfile change here, i just needed to install. i'll pull it from the PR entirely.

@xavdid xavdid merged commit ca8d3e1 into master Nov 1, 2018
@xavdid xavdid deleted the hook-operation branch November 1, 2018 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliangcs eliangcs eliangcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavdid @eliangcs