[schema] Allow RefResources to have commas in the labels #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
commented
Aug 9, 2019
| @@ -34,8 +34,11 @@ | |||
| } | |||
| }, | |||
| "lint-staged": { | |||
| "*.{js,json}": [ | |||
| "*.{js}": [ | |||
There was a problem hiding this comment.
unrelated change, but there are apparently errors if you try to run eslint on json ¯\_(ツ)_/¯
eliangcs
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
contact.id.firstName,lastNamedynamic dropdown pattern to CLI! I've confirmed it works:contact.id.lastName,firstName,lastName:This involves couple of changes:
resourceproperty toKeySchemasincedynamic: 'contact'is an error in the editorx.y(.z)?. We also now include an optional comma clause (but only 1, I got nervous the regex would get unwieldy. We could also simplify it and just allow commas anywhere, but I worry someone will mess it up and it'll be very unclear why their dynamic dropdown isn't working)Very strictly speaking, this is a semver.major since before it was valid to have
dynamic: 'x'and on this version, it won't be. That said, that wouldn't have produced a working app anyway, so i don't feel too bad about including this in a lesser release if it comes to that.Note that I'm OOO next week, so if this is ✅, I'd appreciate if you merged it for me. Thanks!