-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDE-2085 chore(cli): bump @oclif/plugin-help to ^3.2.14 to patch vulnerability in sub-dependency #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! I understand conventionally you'd use a ^
or ~
to auto upgrade the dependencies. But for the packages in this repo, it's more important not to break, so we always use the exact versions to make sure the installation is as deterministic as possible.
@@ -41,7 +41,7 @@ | |||
"@oclif/command": "1.8.0", | |||
"@oclif/config": "1.17.0", | |||
"@oclif/plugin-autocomplete": "0.3.0", | |||
"@oclif/plugin-help": "3.2.2", | |||
"@oclif/plugin-help": "~3.2.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this repo, we always pin the exact version of a dependency, to be extra safe that nothing breaks due to accidental version bump.
"@oclif/plugin-help": "~3.2.14", | |
"@oclif/plugin-help": "3.2.14", |
I patched a repo at work with this change, but unfortunately a bunch of other stuff breaks. For some reason that dependency patch version bump has a bunch of breaking changes. I'll swing back here and update the PR when I get time |
@mrjackdavis At Seal Security we backport security patches and release them freely to the community. So instead of upgrading If you have any questions, feel free to contact us. |
Fixed in #739. Thanks for flagging this issue! |
fixes #555