feat(cli): Support TS for zapier scaffold [IQQ-1831]
#884
+1,713
−780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkcranny
changed the title
zapier scaffold [IQQ-1831]zapier scaffold [IQQ-1831]
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
kola-er
reviewed
Oct 28, 2024
|
Thanks @tkcranny. Left some comments mostly on naming and refactoring. Note that there's conflict in the docs. |
This allows for more settings to be added (i.e. isTypeScript)
This will help with TS AST transformations
tkcranny
force-pushed
the
IQQ-1831-ts-scaffold
branch
from
d6b2a96 to
a3a003f
Compare
FokkeZB
suggested changes
Nov 1, 2024
kola-er
reviewed
Nov 4, 2024
Comment on lines
+46
to
+58
| // useful if your `searches` and `creates` return sparse objects | ||
| // get: { | ||
| // display: { | ||
| // label: 'Get <%= NOUN %>', | ||
| // description: 'Gets a <%= LOWER_NOUN %>.' | ||
| // }, | ||
| // operation: { | ||
| // inputFields: [ | ||
| // {key: 'id', required: true} | ||
| // ], | ||
| // perform: defineMe | ||
| // } | ||
| // }, |
There was a problem hiding this comment.
You want to uncomment this?
There was a problem hiding this comment.
This is standard in the JS Resource template, generated when --no-help is not provided for extra docs.
kola-er
reviewed
Nov 4, 2024
kola-er
reviewed
Nov 4, 2024
kola-er
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
zapier scaffoldto support TypeScript applicationsIt will automatically detect TS and JS projects if the
--entryflag isn't provided, so that it can generate and edit the right files in the right places, given TS projects tend to keep their files in./src.A lot of refactoring was done to provide clean ways to distinguish TS vs JS operations.