Skip to content

Conversation

Pelle-Jensen
Copy link
Contributor

Since creating an agreement requires a CampaignRequest instance to be able to specify a campaign and i couldn't find any interface for CampaignRequest i added getters and setters to the class.
Also changed the date time formatting to match up with the rest of the package.

@codecov-commenter
Copy link

Codecov Report

Merging #40 (a44dba3) into 2.x (cb4b837) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x      #40      +/-   ##
============================================
- Coverage     61.20%   60.45%   -0.76%     
- Complexity      436      440       +4     
============================================
  Files            79       80       +1     
  Lines          1441     1459      +18     
============================================
  Hits            882      882              
- Misses          559      577      +18     
Flag Coverage Δ
unittests 60.45% <0.00%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Model/RecurringPayment/CampaignRequest.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4b837...a44dba3. Read the comment docs.

@zaporylie zaporylie enabled auto-merge June 16, 2022 16:17
Copy link
Owner

@zaporylie zaporylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zaporylie zaporylie merged commit a358d04 into zaporylie:2.x Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants