Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async invocation in Python 3 #1006

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Conversation

suriya
Copy link
Contributor

@suriya suriya commented Jul 17, 2021

Description

Removed the encoding of the json message for SNS notification when sys.version is Python 3.

See Miserlou/Zappa#1331

This issue and similar pull request have been open for more than three years. Please accept and merge them into Zappa.

GitHub Issues

Miserlou/Zappa#1323

Copy link

@luistm luistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsha
Copy link

wangsha commented Nov 23, 2021

I had the same issue and confirm this solution works.

@coveralls
Copy link

coveralls commented Nov 23, 2021

Coverage Status

Coverage remained the same at 73.521% when pulling d21531e on suriya:fix-sns-task-1 into ddc3fbb on zappa:master.

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏽 Thanks for the contribution

@kornpow
Copy link

kornpow commented Dec 13, 2021

Just hit this error today, cant wait for the merge!

@kornpow
Copy link

kornpow commented Dec 18, 2021

I was able to build this into a wheel and test it out! Once I got it installed properly I was able to get my function to call SNS

@task_sns
def longrunner(delay, msg):
    sleep(float(delay))
    return f"testing task: {msg}"

@javulticat javulticat merged commit 86a471c into zappa:master Dec 29, 2021
Ian288 pushed a commit to tackle-io/Zappa that referenced this pull request Jul 11, 2023
See Miserlou/Zappa#1331

Co-authored-by: hellno <hellno@users.noreply.github.com>
Co-authored-by: javulticat <31746850+javulticat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants