-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async invocation in Python 3 #1006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I had the same issue and confirm this solution works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍🏽 Thanks for the contribution
Just hit this error today, cant wait for the merge! |
I was able to build this into a wheel and test it out! Once I got it installed properly I was able to get my function to call SNS
|
See Miserlou/Zappa#1331 Co-authored-by: hellno <hellno@users.noreply.github.com> Co-authored-by: javulticat <31746850+javulticat@users.noreply.github.com>
Description
Removed the encoding of the json message for SNS notification when sys.version is Python 3.
See Miserlou/Zappa#1331
This issue and similar pull request have been open for more than three years. Please accept and merge them into Zappa.
GitHub Issues
Miserlou/Zappa#1323