Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading credentials for save-python-settings-file #1008

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

suriya
Copy link
Contributor

@suriya suriya commented Jul 18, 2021

Description

Loading AWS Credentials and creating AWS Client classes take a lot of
time. We do not need to do that for the save-python-settings-file
command.

This is a minor change

suriya and others added 2 commits July 18, 2021 07:02
Loading AWS Credentials and creating AWS Client classes take a lot of
time. We do not need to do that for the save-python-settings-file
command.
Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the in comparison, a list is not required here. I would use a tuple in this case, but not a major issue.

@coveralls
Copy link

coveralls commented Nov 19, 2022

Coverage Status

coverage: 74.736%. remained the same when pulling a1bfab4 on suriya:speedup-save-python-settings-file into 7a9a5ad on zappa:master.

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monkut monkut merged commit 3cbe342 into zappa:master Oct 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants