Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Executing in Response to AWS Events" section in README.md #1258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MirzaBaig715
Copy link

@MirzaBaig715 MirzaBaig715 commented Jul 3, 2023

Description

Update the README.md for Executing in Response to AWS Events.

GitHub Issues

AWS Documentation supports both FIFO and Standard queues to trigger lambda events. As stated in AWS documentation: Lambda event source mappings support standard queues and first-in, first-out (FIFO) queues.

Update docs for Executing in Response to AWS Events section.
Added AWS Documentation link for SQS
@MirzaBaig715 MirzaBaig715 changed the title Update Executing in Response to AWS Events section in README.md Update "Executing in Response to AWS Events" section in README.md Jul 3, 2023
@coveralls
Copy link

Coverage Status

coverage: 74.536% (+0.1%) from 74.396% when pulling 1283910 on MirzaBaig715:master into 0b1eab1 on zappa:master.

Copy link

github-actions bot commented Apr 3, 2024

Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

@github-actions github-actions bot added the no-activity [Bot] Closing soon if no new activity label Apr 3, 2024
@davidgolden
Copy link

Would be great to get this merged, since the current Zappa documentation is now out of date.

Old AWS Docs which state that only Standard Queues are supported by Lambda: https://web.archive.org/web/20190112132734/https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html

New AWS Docs which state that Lambda supports both Standard and FIFO Queues: https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html

@github-actions github-actions bot added needs-review Needs attention from a maintainer and removed no-activity [Bot] Closing soon if no new activity labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Needs attention from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants