Update and lock linting tool versions to keep dev env stable #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javulticat
added
dependencies
dev-tools
needs-review
javulticat
force-pushed
the
jav/lint-update
branch
from
1d7b46e
to
7c42ebf
Compare
javulticat
added
the
blocking
1 task
monkut
approved these changes
Feb 6, 2024
javulticat
removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recently released version of
blackis now causing CI runs to fail on other PRs. This PR updatesblack(and accepts the changes it wants to make, which seems to be that it wanted to add a line of whitespace in a couple files) along with our other linting tools and pins their versions to keep our development and CI environments stable. A slightly older dev tool is better than a dev tool that is capable of breaking our CI at any moment and preventing PRs from being merged.Going forward, we can set up an automated tool like Dependabot that will automatically generate PRs that update our dev tools when new versions are released.
Blocking
This issue is preventing the CI pipeline from running successfully, so all PRs are likely blocked by this. This was specifically observed in #1300.