Enable Firefox/Edge in integration tests #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great job, no security vulnerabilities found in this Pull Request |
thc202
force-pushed
the
itests-browsers
branch
3 times, most recently
from
b6c8c6d to
485b28c
Compare
psiinon
approved these changes
Jun 24, 2025
Use Firefox and Edge along with Chrome. Replace Playwright with Selenium, which allows to use Firefox with extensions. Extract base driver class since most code is common to all browsers. Extract "ZAP" server to make it easier to use. Update all test cases to use Selenium. Update test timeout to allow all browsers enough time to load. Signed-off-by: thc202 <thc202@gmail.com>
kingthorin
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Firefox and Edge along with Chrome.
Replace Playwright with Selenium, which allows to use Firefox with extensions.
Extract base driver class since most code is common to all browsers.
Extract "ZAP" server to make it easier to use.
Update all test cases to use Selenium.
Update test timeout to allow all browsers enough time to load.