Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requester: Option to manipulate Host header #4952

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Sep 29, 2023

Overview

Adds a button to the requester dialogs for updating the host header.
If disabled then the host header can be manipulated by the user 😁

Related Issues

zaproxy/zaproxy#1318

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Signed-off-by: Simon Bennetts <psiinon@gmail.com>
@thc202
Copy link
Member

thc202 commented Sep 29, 2023

Thank you!

@kingthorin
Copy link
Member

Should the build file be updated to require core >=2.14.0 ?

@psiinon
Copy link
Member Author

psiinon commented Sep 29, 2023

Nope, this doesnt depend on any core changes - the other PR is independant.

@kingthorin
Copy link
Member

No I know but I thought on the call you suggested we were going to hold on releasing this till 2.14

@psiinon
Copy link
Member Author

psiinon commented Sep 29, 2023

Oh right, see what you mean.
I was thinking we would just not release it 😁

@kingthorin
Copy link
Member

Okay that's fine too.

@psiinon psiinon merged commit 4bb97d6 into zaproxy:main Sep 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants