Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pscanrules (all): Various alert text fixes (periods and whitespace(s)) #5526

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Jun 21, 2024

Overview

  • CHANGELOG > Added fix note.
  • Messages.properties > Updated various resource messages, removed some that were unused.
  • UnitTests > Updated as needed.
  • ScanRules > Removed methods using empty resource messages.

Related Issues

#5522

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin kingthorin force-pushed the pscan-oi branch 5 times, most recently from cd9e722 to a2cc57e Compare June 27, 2024 10:40
- CHANGELOG > Added fix note.
- Messages.properties > Updated various resource messages, removed some
that were unused.
- UnitTests > Updated as needed.
- ScanRules > Removed methods using empty resource messages.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Got all those, I hope.

@thc202
Copy link
Member

thc202 commented Jun 27, 2024

Thank you!

@psiinon psiinon merged commit 999929d into zaproxy:main Jun 27, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@kingthorin kingthorin deleted the pscan-oi branch June 27, 2024 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants