ascanrules: add SqlInjectionScanRule unit tests for boolean based #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
thc202
changed the title
thc202
reviewed
Oct 8, 2024
addOns/ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionScanRule.java
Outdated
Show resolved
Hide resolved
...anrules/src/test/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
FiveOFive
force-pushed
the
sqli-boolean-based-unit-tests
branch
2 times, most recently
from
8fcb9d6 to
ff7eae4
Compare
This was referenced Oct 30, 2024
Signed-off-by: FiveOFive <FiveOFive@users.noreply.github.com>
FiveOFive
force-pushed
the
sqli-boolean-based-unit-tests
branch
from
ff7eae4 to
366804e
Compare
8 tasks
kingthorin
added
the
waiting-for:zaproxy-team-wip
thc202
removed
the
waiting-for:zaproxy-team-wip
kingthorin
reviewed
Mar 6, 2025
| class BooleanBasedSqlInjection { | ||
|
|
||
| @Test | ||
| void shouldAlert_ANDTrueMatches_ANDFalseDoesNotMatch() throws Exception { |
There was a problem hiding this comment.
I understand that you're trying to make the naming/conditions more clear however I think we'd like to stick with the Java naming convention(s).
So maybe: shouldAlertWhenCheckAndTrueMatchesCCheckAndFalseDoesNotMatch
Similar for those below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Briefly describe the purpose, goals, and changes or improvements made in this pull request.
Related Issues
Specify any related issues or pull requests by linking to them. zaproxy/zaproxy#8652
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.