Sequence: Support for JSON reports #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
sequence/report1
branch
from
201c221
to
f221f0f
Compare
|
This has conflicts now. |
psiinon
force-pushed
the
sequence/report1
branch
3 times, most recently
from
27e9bf9
to
8608824
Compare
|
Ready to review, but I have found one failing edge case that I'm looking into.. |
psiinon
force-pushed
the
sequence/report1
branch
from
8608824
to
16a0c8e
Compare
|
OK, the edge case was Zest not handling a req with a token in the URL - now fixed (with a test too!) |
kingthorin
reviewed
Nov 4, 2024
...orts/src/test/resources/org/zaproxy/addon/reports/resources/basic-traditional-json-plus.json
Outdated
Show resolved
Hide resolved
...sequence/src/main/resources/org/zaproxy/zap/extension/sequence/resources/Messages.properties
Show resolved
Hide resolved
addOns/zest/src/main/java/org/zaproxy/zap/extension/zest/ZestZapUtils.java
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
sequence/report1
branch
2 times, most recently
from
1624d39
to
62543d3
Compare
|
Now with unit tests 😁 |
psiinon
force-pushed
the
sequence/report1
branch
from
62543d3
to
6a29a85
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
sequence/report1
branch
from
6a29a85
to
f25203c
Compare
thc202
approved these changes
Nov 5, 2024
|
Thank you! |
kingthorin
approved these changes
Nov 5, 2024
|
Do we want to update the help for these?
and for that matter the HTML variants when I get them finished. |
|
@kingthorin yes, definitely. Can you do that? 😁 |
|
Yup, no problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As per title.
Note that I didnt add the 'highestAlert' field - that looks to be a bit tricky, and not really needed for JSON reports?
Might want it for HTML ones though 😁
Also added the alertId so that they can be cross referenced.
Related Issues
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.