Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: Fix duplicate "Save URLs..." options #6012

Merged
merged 1 commit into from
Dec 20, 2024
Merged

exim: Fix duplicate "Save URLs..." options #6012

merged 1 commit into from
Dec 20, 2024

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Dec 16, 2024 •
edited
Loading

Overview

  • Duplicate or missing "Save URLs..." entries in the Export menu.
  • The "Save All URLs..." export option was saving only the selected URLs.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@ricekot ricekot mentioned this pull request Dec 16, 2024
Merged
8 tasks
@psiinon
Copy link
Member

psiinon commented Dec 16, 2024

I think we should discuss these changes first 😁

@ricekot
Copy link
Member Author

ricekot commented Dec 16, 2024

#6012 (comment)

Sure, but in any case we should fix the duplicate items in the Export menu
image

@psiinon
Copy link
Member

psiinon commented Dec 16, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 6bb814a8-b51e-4ad2-a658-bd4c15a42cb9

No New Or Fixed Issues Found

@ricekot
exim: Fix duplicate "Save URLs..." options
a7fa0e4 
Also, fix bugs where:
- the Save URLs... options were disappearing from the Export menu
- the Save All URLs... option was only saving the selected URLs

Signed-off-by: ricekot <git@ricekot.com>
@ricekot ricekot force-pushed the exim/remove-export-urls branch from 95906e0 to a7fa0e4 Compare December 19, 2024 17:25
@ricekot
Copy link
Member Author

ricekot commented Dec 19, 2024

Updated with the approach we discussed offline.

@thc202 thc202 changed the title exim: Remove URL export options from Export menu exim: Fix duplicate "Save URLs..." options Dec 20, 2024
@thc202
Copy link
Member

thc202 commented Dec 20, 2024

Thank you!

kingthorin
kingthorin approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin kingthorin merged commit a463846 into zaproxy:main Dec 20, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@ricekot ricekot deleted the exim/remove-export-urls branch December 20, 2024 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingthorin kingthorin kingthorin approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricekot @psiinon @thc202 @kingthorin