retire: Fix False Positive issue #6021
Merged
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
kingthorin
force-pushed
the
retire-risk-bug
branch
6 times, most recently
from
737d6e5 to
bdce229
Compare
thc202
reviewed
Dec 19, 2024
addOns/retire/src/main/java/org/zaproxy/addon/retire/model/Repo.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/main/java/org/zaproxy/addon/retire/model/Repo.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/main/java/org/zaproxy/addon/retire/model/Vulnerability.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/test/java/org/zaproxy/addon/retire/RetireTestUtils.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/test/java/org/zaproxy/addon/retire/UpstreamJsRepositoryUnitTest.java
Show resolved
Hide resolved
addOns/retire/src/test/java/org/zaproxy/addon/retire/UpstreamJsRepositoryUnitTest.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/test/java/org/zaproxy/addon/retire/UpstreamJsRepositoryUnitTest.java
Outdated
Show resolved
Hide resolved
addOns/retire/src/test/java/org/zaproxy/addon/retire/model/RepoUnitTest.java
Outdated
Show resolved
Hide resolved
|
We are going to have to release this to 2.15. Happy if the changes are done here in another commit but also if done in a follow up PR. |
kingthorin
force-pushed
the
retire-risk-bug
branch
from
bdce229 to
90013c4
Compare
|
Okay, if this is good I'll add the 2.15 commit. |
kingthorin
force-pushed
the
retire-risk-bug
branch
3 times, most recently
from
177e1cf to
11ce8f6
Compare
thc202
reviewed
Dec 19, 2024
addOns/retire/src/test/java/org/zaproxy/addon/retire/model/UpstreamJsRepositoryUnitTest.java
Outdated
Show resolved
Hide resolved
thc202
reviewed
Dec 19, 2024
addOns/retire/src/main/java/org/zaproxy/addon/retire/model/Repo.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
retire-risk-bug
branch
from
11ce8f6 to
0619b9c
Compare
|
Done & done |
|
lgtm |
psiinon
approved these changes
Dec 19, 2024
kingthorin
force-pushed
the
retire-risk-bug
branch
from
e6c68b8 to
ea69e87
Compare
- CHANGELOG > Added fix note. - Repo > Added handling for fall through of essentially "empty" object. - Tests > Added additional unit tests/assertions. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
retire-risk-bug
branch
from
ea69e87 to
c4f7200
Compare
thc202
approved these changes
Dec 19, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
Reported via direct email and dev group.
Checklist
./gradlew spotlessApplyfor code formatting