Client: Spider tasks GUI #6030
Merged
Client: Spider tasks GUI #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
psiinon
force-pushed
the
client/action-gui
branch
from
8396c91 to
417d327
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
client/action-gui
branch
from
417d327 to
b447581
Compare
thc202
approved these changes
Dec 23, 2024
|
Thank you! |
kingthorin
reviewed
Dec 23, 2024
Comment on lines
+356
to
+366
| String tag = parameters.get("tagName"); | ||
| if (tag != null) { | ||
| switch (tag) { | ||
| case "A": | ||
| return Constant.messages.getString( | ||
| "client.spider.panel.table.details.link", | ||
| parameters.get("href"), | ||
| parameters.get("text")); | ||
| case "BUTTON": | ||
| return Constant.messages.getString( | ||
| "client.spider.panel.table.details.button", parameters.get("text")); |
There was a problem hiding this comment.
No need for it to block this, but it seems we should have constants for a bunch of field/item names.
There was a problem hiding this comment.
This code will be changed once the spider starts using its own proxies/client map.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a GUI for the client spider tasks. I'll update this PR once that has been merged.
Related Issues
Depends on #6017
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.