Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Clarify error message #6250

Merged
merged 1 commit into from
Mar 12, 2025
Merged

openapi: Clarify error message #6250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions addOns/openapi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Fixed
- Correct definition detection while spidering.

### Changed
- Clarified an error message which occurs in automation if there's a problem importing.

## [44] - 2025-01-09
### Changed
- Update minimum ZAP version to 2.16.0.
Expand Down
4 changes: 2 additions & 2 deletions addOns/openapi/src/main/java/org/zaproxy/zap/extension/openapi/automation/OpenApiJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public void runJob(AutomationEnvironment env, AutomationProgress progress) {
Constant.messages.getString(
"openapi.automation.error.misc",
this.getName(),
targetUrl,
targetUrl == null ? file.getAbsolutePath() : targetUrl,
error));
}
}
Expand Down Expand Up @@ -178,7 +178,7 @@ public void runJob(AutomationEnvironment env, AutomationProgress progress) {
Constant.messages.getString(
"openapi.automation.error.misc",
this.getName(),
targetUrl,
targetUrl == null ? apiUrl : targetUrl,
error));
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...penapi/src/main/resources/org/zaproxy/zap/extension/openapi/resources/Messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ openapi.automation.dialog.title = OpenAPI Job
openapi.automation.error.file = Job {0} cannot read file: {1}
openapi.automation.error.misc = Job {0} target: {1} error: {2}
openapi.automation.error.nofile = Cannot access file: {0}
openapi.automation.error.url = Job {0} target: {1} invalid API URL: {2}
openapi.automation.error.url = Job {0} target URL: {1} invalid API URL: {2}
openapi.automation.info.urlsadded = Job {0} added {1} URLs
openapi.automation.name = OpenAPI Automation

Expand Down