Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node api generation #5088

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Node api generation #5088

merged 4 commits into from
Oct 31, 2018

Conversation

binarymist
Copy link
Contributor

@binarymist binarymist commented Oct 29, 2018 •
edited
Loading

  • Provided backwards compatibility for those wishing to continue using callbacks, while those wishing to take advantage of promises can now do so
  • The apiKey is now only required on the initial ZapClient instantiation

Addresses #5044

@binarymist
Copy link
Contributor Author

binarymist commented Oct 30, 2018 •
edited
Loading

Switching to tag 2.7.0 as suggested in zaproxy/zap-api-nodejs#1 (comment) yields:

Information:java: Errors occurred while compiling module 'zaproxy'
Information:javac 1.8.0_181 was used to compile java sources
Information:30/10/18 2:47 PM - Compilation completed with 18 errors and 0 warnings in 9s 664ms
/home/agiledev/Source/zaproxy/src/org/parosproxy/paros/extension/history/PopupMenuEmbeddedBrowser.java
Error:(41, 29) java: package edu.stanford.ejalbert does not exist
Error:(42, 39) java: package edu.stanford.ejalbert.exception does not exist
Error:(43, 39) java: package edu.stanford.ejalbert.exception does not exist
Error:(56, 13) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.parosproxy.paros.extension.history.PopupMenuEmbeddedBrowser
Error:(103, 17) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.parosproxy.paros.extension.history.PopupMenuEmbeddedBrowser
Error:(109, 48) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.parosproxy.paros.extension.history.PopupMenuEmbeddedBrowser
Error:(110, 34) java: cannot find symbol
  symbol:   class BrowserLaunchingInitializingException
  location: class org.parosproxy.paros.extension.history.PopupMenuEmbeddedBrowser
Error:(110, 74) java: cannot find symbol
  symbol:   class UnsupportedOperatingSystemException
  location: class org.parosproxy.paros.extension.history.PopupMenuEmbeddedBrowser
/home/agiledev/Source/zaproxy/src/org/zaproxy/zap/utils/DesktopUtils.java
Error:(9, 29) java: package edu.stanford.ejalbert does not exist
Error:(10, 39) java: package edu.stanford.ejalbert.exception does not exist
Error:(11, 39) java: package edu.stanford.ejalbert.exception does not exist
Error:(27, 20) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(102, 24) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(103, 32) java: cannot find symbol
  symbol:   class BrowserLaunchingInitializingException
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(103, 71) java: cannot find symbol
  symbol:   class UnsupportedOperatingSystemException
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(111, 32) java: cannot find symbol
  symbol:   class BrowserLaunchingInitializingException
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(111, 71) java: cannot find symbol
  symbol:   class UnsupportedOperatingSystemException
  location: class org.zaproxy.zap.utils.DesktopUtils
Error:(113, 40) java: cannot find symbol
  symbol:   class BrowserLauncher
  location: class org.zaproxy.zap.utils.DesktopUtils

@binarymist binarymist mentioned this pull request Oct 30, 2018
Merged
10 tasks
@thc202
Copy link
Member

thc202 commented Oct 30, 2018

Are all the libraries under the lib directory in the module's dependencies?

@binarymist
Copy link
Contributor Author

I haven't removed any

@thc202
Copy link
Member

thc202 commented Oct 30, 2018

Right, but you might need to add.

@thc202
Copy link
Member

thc202 commented Oct 31, 2018

Thanks!

This was referenced Oct 31, 2018
Merged
Merged
Merged
@psiinon psiinon merged commit 0117385 into zaproxy:develop Oct 31, 2018
@lock
Copy link

lock bot commented Oct 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thc202 thc202 thc202 approved these changes

@psiinon psiinon psiinon approved these changes

Assignees
No one assigned
Labels
Type-Task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binarymist @thc202 @psiinon