Skip to content

Commit

Permalink
update readme to address new install requirements
Browse files Browse the repository at this point in the history
go1.12+ and need to execute the script directly in `sudo bash`... ugh. also evidently master had compile errors?????
  • Loading branch information
zaquestion committed Oct 4, 2019
1 parent d114488 commit 45bb615
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ scoop install lab

Installs lab into `/usr/local/bin/`
```
curl -s https://raw.githubusercontent.com/zaquestion/lab/master/install.sh | bash
curl -s https://raw.githubusercontent.com/zaquestion/lab/master/install.sh | sudo bash
```
NOTE: Please take care when executing scripts in this fashion. Make sure you
trust the developer providing the script and consider peaking at the install
script itself (ours is pretty simply ;)

### PreBuilt Binaries

Expand All @@ -56,7 +59,7 @@ Head to the [releases](https://github.com/zaquestion/lab/releases) page and down
### Source

Required
* [Go 1.11+](https://golang.org/doc/install)
* [Go 1.12+](https://golang.org/doc/install)

```
git clone git@github.com:zaquestion/lab
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,5 @@ require (
)

replace github.com/spf13/cobra => github.com/rsteube/cobra v0.0.1-zsh-completion-custom

go 1.13
4 changes: 2 additions & 2 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ _can_install() {
}

if ! _can_install && [[ $EUID != 0 ]]; then
sudo "$0" "$@"
exit "$?"
echo "Must be run as sudo"
exit 1
fi

if ! _can_install; then
Expand Down
2 changes: 0 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ package main
import (
"log"
"os"
"os/user"
"path"
"runtime"
"strings"

"github.com/spf13/viper"
Expand Down

0 comments on commit 45bb615

Please sign in to comment.