cmd: fix return value checks and statements

golint complained about some return values not being used/checked
accordingly. This patch correct these.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>

cmd/ci_trace.go

@@ -109,7 +109,12 @@ func doTrace(ctx context.Context, w io.Writer, pid interface{}, pipelineID int,
 			}
 			fmt.Fprintf(w, "Showing logs for %s job #%d\n", job.Name, job.ID)
 		})
+
 		_, err = io.CopyN(ioutil.Discard, trace, offset)
+		if err != nil {
+			return err
+		}
+
 		lenT, err := io.Copy(w, trace)
 		if err != nil {
 			return err

cmd/label.go

@@ -10,7 +10,6 @@ var labelCmd = &cobra.Command{
 	PersistentPreRun: LabPersistentPreRun,
 	Run: func(cmd *cobra.Command, args []string) {
 		cmd.Help()
-		return
 	},
 }
 

cmd/project_browse.go

@@ -12,6 +12,9 @@ var projectBrowseCmd = &cobra.Command{
 	PersistentPreRun: LabPersistentPreRun,
 	Run: func(cmd *cobra.Command, args []string) {
 		rn, _, err := parseArgsRemoteAndID(args)
+		if err != nil {
+			log.Fatal(err)
+		}
 
 		p, err := lab.FindProject(rn)
 		if err != nil {

cmd/show_common.go

@@ -281,7 +281,7 @@ func printDiscussions(discussions []*gitlab.Discussion, since string, idstr stri
 		}
 	}
 
-	if sinceIsSet == false {
+	if !sinceIsSet {
 		config.WriteConfigEntry(CommandPrefix+issueEntry, newAccessTime, "", "")
 	}
 }

cmd/util.go

@@ -81,6 +81,9 @@ func getBranchMR(rn, branch string) int {
 	var num int = 0
 
 	mrBranch, err := git.UpstreamBranch(branch)
+	if err != nil {
+		log.Fatal(err)
+	}
 	if mrBranch == "" {
 		// Fall back to local branch
 		mrBranch = branch
@@ -316,6 +319,10 @@ func parseArgsWithGitBranchMR(args []string) (string, int64, error) {
 		err    error
 	)
 	s, i, err := parseArgsRemoteAndID(args)
+	if err != nil {
+		return "", 0, err
+	}
+
 	if i == 0 {
 		s, branch, err = parseArgsRemoteAndString(args)
 		if err != nil {