Merge pull request #629 from bmeneguele/fix-deprecate-flags

mr,issue,snippet: make shorthand flags deprecated
zaquestion · Mar 10, 2021 · c79e750 · c79e750
2 parents f0c60c5 + 8b27899
commit c79e750
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/cmd/issue.go b/cmd/issue.go
@@ -36,7 +36,10 @@ var issueCmd = &cobra.Command{
 
 func init() {
 	issueCmd.Flags().BoolP("list", "l", false, "list issues on a remote")
+	issueCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	issueCmd.Flags().BoolP("browse", "b", false, "view issue <id> in a browser")
+	issueCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	issueCmd.Flags().StringP("close", "d", "", "close issue <id> on remote")
+	issueCmd.Flags().MarkDeprecated("close", "use the \"close\" subcommand instead")
 	RootCmd.AddCommand(issueCmd)
 }
diff --git a/cmd/mr.go b/cmd/mr.go
@@ -37,7 +37,10 @@ var mrCmd = &cobra.Command{
 
 func init() {
 	mrCmd.Flags().BoolP("list", "l", false, "list merge requests on a remote")
+	mrCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	mrCmd.Flags().BoolP("browse", "b", false, "view merge request <id> in a browser")
+	mrCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	mrCmd.Flags().StringP("close", "d", "", "close merge request <id> on remote")
+	mrCmd.Flags().MarkDeprecated("close", "use the \"close\" subcommand instead")
 	RootCmd.AddCommand(mrCmd)
 }
diff --git a/cmd/snippet.go b/cmd/snippet.go
@@ -52,8 +52,11 @@ var (
 func init() {
 	snippetCmd.PersistentFlags().BoolVarP(&global, "global", "g", false, "create as a personal snippet")
 	snippetCmd.Flags().BoolP("list", "l", false, "list snippets")
+	snippetCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	snippetCmd.Flags().BoolP("browse", "b", false, "browse snippets")
+	snippetCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	snippetCmd.Flags().StringP("delete", "d", "", "delete snippet with id")
+	snippetCmd.Flags().MarkDeprecated("delete", "use the \"delete\" subcommand instead")
 	// Create flags added in snippetCreate.go
 	RootCmd.AddCommand(snippetCmd)
 }