(refactor) BranchPushed pull out FindProject call and put more inform…

…ation into calling error message

cmd/mergeRequest.go

@@ -7,9 +7,9 @@ import (
 // mrCmd represents the mr command
 var mergeRequestCmd = &cobra.Command{
 	Use:   "merge-request [remote]",
-	Short: "Open a merge request on GitLab",
-	Long:  `Currently only supports MRs into master`,
-	Args:  cobra.ExactArgs(0),
+	Short: mrCreateCmd.Short,
+	Long:  mrCreateCmd.Long,
+	Args:  mrCreateCmd.Args,
 	Run:   runMRCreate,
 }
 

cmd/mrCreate.go

@@ -50,8 +50,12 @@ func runMRCreate(cmd *cobra.Command, args []string) {
 		log.Fatal(err)
 	}
 
-	if !lab.BranchPushed(sourceProjectName, branch) {
-		log.Fatal("aborting MR, branch not present on remote: ", sourceRemote)
+	p, err := lab.FindProject(sourceProjectName)
+	if err != nil {
+		log.Fatal(err)
+	}
+	if !lab.BranchPushed(p.ID, branch) {
+		log.Fatalf("aborting MR, branch %s not present on remote %s. did you forget to push?", branch, sourceRemote)
 	}
 
 	targetRemote := forkedFromRemote

internal/gitlab/gitlab.go

@@ -260,13 +260,8 @@ func IssueClose(pid interface{}, id int) error {
 }
 
 // BranchPushed checks if a branch exists on a GitLab project
-func BranchPushed(project, branch string) bool {
-	p, err := FindProject(project)
-	if err != nil {
-		return false
-	}
-
-	b, _, err := lab.Branches.GetBranch(p.ID, branch)
+func BranchPushed(pid interface{}, branch string) bool {
+	b, _, err := lab.Branches.GetBranch(pid, branch)
 	if err != nil {
 		return false
 	}