Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need License.md #1

Closed
adamryman opened this issue Aug 27, 2017 · 1 comment
Closed

Need License.md #1

adamryman opened this issue Aug 27, 2017 · 1 comment

Comments

@adamryman
Copy link
Contributor

I recommend Unlicensed.
@zaquestion
Copy link
Owner

👍 Added

@rachidbch rachidbch mentioned this issue Oct 10, 2019
Closed
@prarit prarit mentioned this issue Sep 2, 2020
Closed
@prarit prarit mentioned this issue Oct 31, 2020
Merged
prarit added a commit that referenced this issue Oct 31, 2020
@prarit
mr_list_test: Fix Test_mrListByTargetBranch
dcf0d91 
The Test_mrListByTargetBranch is failing with

--- FAIL: Test_mrListByTargetBranch (0.97s)
    mr_list_test.go:138:
        	Error Trace:	mr_list_test.go:138
        	Error:      	Not equal:
        	            	expected: "#1 Test MR for lab list"
        	            	actual  : "#6 test award emoji"

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-#1 Test MR for lab list
        	            	+#6 test award emoji
        	Test:       	Test_mrListByTargetBranch

because test MR #6 was modified and now has an 'updated_at' date newer
than #1.

Change the Test_mrListByTargetBranch test so that it correctly detects #1
again.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
@prarit prarit mentioned this issue Mar 25, 2021
Merged
bmeneg pushed a commit that referenced this issue Mar 26, 2021
@prarit
mr_test: Add wildcard support to cleanupMR()
0f4aeea 
The problem with cmd/mr_test.go:cleanupMR() is that the way
it is called is insufficient to clean up a failed test. The
sequence that is leading to failures is, for example,

test run #1:

Test_mrCmd() runs.
Test_mrCmd_MR_description_and_options() runs and fails leaving,
for example, a Merge Request with description "Fancy Description".
test run #1 fails.

test run #2:
Test_mrCmd() runs and fails because a Merge Request with
description "Fancy Description" exists. It is not "found" by
the cleanupMR() function because Test_mrCmd()'s call is looking
for a description of "mr title".
test run #2 fails.

test run #3

(with my changes from the first commit) cleans things up.
test run #3 fails.

test run #4 should succeed.

This is a painful way to test.  Since only one MR is created at a time for
the test branch the code should just clean up any existing MR.

Add wildcard support to the cleanupMR() function.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamryman @zaquestion