-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--help, help, and lab/git are all inconsistent #107
Comments
Thanks for reporting, will get a fix up for this today or tomorrow. I'm definitely guilting of missing some edge cases that fall outside my workflow so I really appreciate the report |
This is a little trickier than I thought it would be. It requires hacking around cobras built in help functionality. I managed to get the help output consistent and in the process broke all of |
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
I think the above #108 addresses all of the issues here. It deserves some thorough tests and review given the borderline hacks required to make this work with cobra. Should be able to get tests in place this weekend and planning to upgrade cobra to see if anything in a newer version that can be put to use. |
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
[#107] (bug) align lab help functionality with git help and --help
Fixed in #108 will go out in 0.9.5 |
After aliasing
git
tolab
, I noticed there are several inconsistencies to the help dialog.git --help
,git help
andgit
all return different output.git --help
returns the output oflab --help
,git help
returns the output ofhub --help
andgit
returns the output oflab
which is a combination of hub + lab.All of these should be returning the same output. If
hub
isn't installed,lab
andlab --help
should both be returning the decoratedgit --help
output. If it is installed, it should be decorating thehub --help
output.The text was updated successfully, but these errors were encountered: