Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab issue search #208

Closed
magiraud opened this issue Aug 10, 2018 · 5 comments
Closed

lab issue search #208

magiraud opened this issue Aug 10, 2018 · 5 comments

Comments

@magiraud
Copy link

A command could list issues using the search attribute of the API.

@magiraud
Copy link
Author

Or it could be a flag to lab issue list.

@claytonrcarter
Copy link
Collaborator

I like the idea of doing this via lab issue list --search, though I'm not sure what to do about a short flag as -s is already taken by --state.

@zaquestion if you're open to this, I would be happy to submit a PR.

@zaquestion
Copy link
Owner

I tend to think search should come in as a positional argument, but I don't fully understand why I think this to begin with...

I would accept lab issue list [remote [search]] for sure. Otherwise, I'd like to hear rational to do so differently and in turn see lab project list [search] updated to match.

@claytonrcarter
Copy link
Collaborator

This makes sense. The only concern I would have is disambiguating the remote and the search term in cases when you want to search for a term that also happens to be the name of a remote. Probably not a super common case, but I thought it was worth noting.

Also, do you expect [search] to be a single string, or would you want all of the remaining arguments to be used as the search terms? For example lab issue list "my search terms" vs lab issue list my search terms

@claytonrcarter
Copy link
Collaborator

This was merged in #242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants