Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue list search #242

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Conversation

claytonrcarter
Copy link
Collaborator

Adds search feature to lab issue list. (See #208) Also aliases list to search, as in lab project list.

lab issue list                        # no change; list all open issues
lab issue list "search terms"         # search issues for "search terms"
lab issue search "search terms"       # ditto
lab issue list remote "search terms"  # search "remote" for issues with "search terms"

Also, hope its OK I took the liberty to rename the parseArgs* functions to make them a little more clear.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #242 into master will increase coverage by 0.2%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #242     +/-   ##
=========================================
+ Coverage   68.11%   68.32%   +0.2%     
=========================================
  Files          41       42      +1     
  Lines        2158     2251     +93     
=========================================
+ Hits         1470     1538     +68     
- Misses        541      554     +13     
- Partials      147      159     +12
Impacted Files Coverage Δ
cmd/issue_list.go 93.93% <100%> (+1.08%) ⬆️
cmd/root.go 72.93% <70.37%> (-0.66%) ⬇️
internal/git/edit.go 76.62% <0%> (-2.79%) ⬇️
cmd/issue_note.go 79.54% <0%> (ø)
internal/gitlab/gitlab.go 42.47% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5416dcf...845071d. Read the comment docs.

Copy link
Owner

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps! these comments never got submitted my bad!!

cmd/root.go Outdated Show resolved Hide resolved
cmd/issue_list.go Show resolved Hide resolved
@zaquestion zaquestion merged commit 9ba0548 into zaquestion:master Nov 15, 2018
@zaquestion zaquestion added this to the 0.15.0 milestone Nov 15, 2018
@claytonrcarter claytonrcarter deleted the issue-list-search branch November 15, 2018 20:45
@claytonrcarter claytonrcarter mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants