-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting just LAB_CORE_HOST does nothing #269
Comments
@mpickering This is correct, lab needs all 3 values to operate. If it can't find them and the config file doesn't exist it assumes it needs to prompt you for the values. You're correct that lab ignores the variables in this case. I think theres a case to be made that we should only require host and user since for public uses I believe we don't need the token. I'm not sure what the request here is though.. What would you like lab to do differently? |
I intended to wrap the executable so that our users would only have to provide their token. The wrapper would set What is the username used for btw? Is the token on its own not sufficient? |
You're probably right, these requirements are from the earliest days of lab. Its probably just an API call to get the username, so we probably only need the token. Lab uses it largely for searching and naming remotes |
Will definitely check it out, and contributions welcome. We can change the creds logic to not prompt if we already have an environment variables set. |
we can use the token to look it up
@mpickering I've made some changes to remove the need to set the username explicitly and have lab use I'll get it merged in this week. There are a few other items in the next milestone and I'd like to see if I can get a few more in, but I'll try and do a release this week since theres a good amount in it. |
@mpickering I've release this functionality in |
I have set
LAB_CORE_HOST
to the correct URL for our project but the program still prompts for the gitlab host on the first run. It seems that unless all three variables are set then the others are ignored.The text was updated successfully, but these errors were encountered: