Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token asked for wrong domain #45

Closed
glensc opened this issue Nov 18, 2017 · 2 comments
Closed

token asked for wrong domain #45

glensc opened this issue Nov 18, 2017 · 2 comments
Labels

Comments

@glensc
Copy link
Contributor

glensc commented Nov 18, 2017

$ lab remote -v
Enter default GitLab host (default: https://gitlab.com): https://gitlab.example.net 
Enter default GitLab user: glen
Enter default GitLab token (scope: api ):
Create here: https://gitlab.com/profile/personal_access_tokens[]

should say: https://gitlab.example.net/profile/personal_access_tokens

also, there's some usability issue, the cursor is placed in [], i.e without newline. perhaps print that information before prompting user (swap two last lines)

also, the stty echo needs to be trurned off, not to show token when pasting it to terminal.

@zaquestion
Copy link
Owner

Thanks for reporting!

zaquestion added a commit that referenced this issue Nov 18, 2017
…sues

Use the user-defined GitLab host when printing the token key

fix the cursor to prompt on the "Enter...token" line

dont echo the token when its being entered
zaquestion added a commit that referenced this issue Nov 18, 2017
[#45] (internal/gitlab) fix token asked for wrong domain + display issues
@zaquestion zaquestion added the bug label Nov 18, 2017
@zaquestion
Copy link
Owner

@glensc I've put in a fix, will keep this open for a bit longer to give you a chance to try it out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants