Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependencies #161

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Reduce dependencies #161

merged 4 commits into from
Jun 11, 2018

Conversation

tydavis
Copy link
Contributor

@tydavis tydavis commented Jun 10, 2018

  • Simplify home directory detection, still without the need for cgo. Remove import.
  • Fix typo
  • Undo a mistake where goimports removed a library that was used in the file

@codecov
Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #161 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   76.31%   76.27%   -0.04%     
==========================================
  Files          36       36              
  Lines        1579     1585       +6     
==========================================
+ Hits         1205     1209       +4     
- Misses        261      263       +2     
  Partials      113      113
Impacted Files Coverage Δ
internal/git/git.go 77.95% <ø> (ø) ⬆️
main.go 68.42% <75%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2900ecb...70963f3. Read the comment docs.

Copy link
Owner

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be some gopkg.lock changes to seal the deal? I might be using this in another spot. intenal/config possibly

@zaquestion zaquestion merged commit f446b9a into zaquestion:master Jun 11, 2018
@tydavis tydavis deleted the reduce_dependencies branch June 11, 2018 17:24
@zaquestion zaquestion added this to the 0.12.0 milestone Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants