Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add positional completion to issue edit #254

Merged

Conversation

claytonrcarter
Copy link
Collaborator

#245 landed just after #252, so it missed the completion party. I think that this adds the required code to enable positional completion of [remote] and <id>. @rsteube can you take a peek to make sure I'm doing it right? I copi...based this off of the completions in issue note.

Thanks!

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #254 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage    69.6%   69.62%   +0.02%     
==========================================
  Files          44       44              
  Lines        2441     2443       +2     
==========================================
+ Hits         1699     1701       +2     
  Misses        573      573              
  Partials      169      169
Impacted Files Coverage Δ
cmd/issue_edit.go 86.92% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229e611...d20df7d. Read the comment docs.

@rsteube
Copy link
Collaborator

rsteube commented Nov 29, 2018

@claytonrcarter claytonrcarter merged commit a82eac8 into zaquestion:master Nov 29, 2018
@claytonrcarter claytonrcarter deleted the issue-edit-completion branch November 30, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants