install.sh script fixes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If /tmp is mounted with the noexec option, the execution bit is dropped. Let's make sure to add it back in the install script.
Closed
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 69.56% 69.56%
=======================================
Files 44 44
Lines 2481 2481
=======================================
Hits 1726 1726
Misses 583 583
Partials 172 172Continue to review full report at Codecov.
|
By passing it as the first argument to the script. Not that the argument overrides the environment, in case both are set.
claytonrcarter
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
This looks nice and clean to me, and I'm in favor of merging. I'll leave it to @zaquestion to pull the trigger, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started looking at this script to fix #262, and fixed a few other things while there :)
installing to a custom location is now done by setting the environment variable
PREFIXbefore executing the script; eg.:or
PREFIX=~/.local install.sh